Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotient filter reviewed #579

Draft
wants to merge 54 commits into
base: master
Choose a base branch
from
Draft

Quotient filter reviewed #579

wants to merge 54 commits into from

Conversation

leerho
Copy link
Contributor

@leerho leerho commented Jun 22, 2024

No description provided.

c-dickens and others added 30 commits May 2, 2024 11:14
Added initial QF builder functions
circular table, no extension slots
fixed find_run_start() and removed adjustment in insert_new_run()
//hash_type = XxHash.hashLong ; //HashType.xxh;
}

public boolean rejuvenate(final long key) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'key' is never used.
return success;
}

protected boolean _search(final long largeHash) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
Filter._search
; it is advisable to add an Override annotation.
Hence, the `large_hash` argument is already a hash key that has been generated
by the hashing library (eg xxhash).
*/
protected boolean _insert(final long largeHash) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
Filter._insert
; it is advisable to add an Override annotation.
setFingerprint(index, fingerprint);
}

public String toString() {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
Object.toString
; it is advisable to add an Override annotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants